[PATCH 1/3] dmthin: _notrun when dm-thin setup fails

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



dm-think does not work on device with protection information.  Instead
of failing the tests using it in obscure ways, _norun them.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
 common/dmthin | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/dmthin b/common/dmthin
index 453e43a0499e..a1e1fb8763c0 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -105,13 +105,13 @@ _dmthin_init()
 	# Metadata device
 	DMTHIN_META_TABLE="0 $meta_dev_size linear $dm_backing_dev $meta_dev_offset"
 	_dmsetup_create $DMTHIN_META_NAME --table "$DMTHIN_META_TABLE" || \
-		_fatal "failed to create dm thin meta device"
+		_notrun "failed to create dm thin meta device"
 
 	# Data device
 	local data_dev_offset=$((meta_dev_offset + $meta_dev_size))
 	DMTHIN_DATA_TABLE="0 $data_dev_size linear $dm_backing_dev $data_dev_offset"
 	_dmsetup_create $DMTHIN_DATA_NAME --table "$DMTHIN_DATA_TABLE" || \
-		_fatal "failed to create dm thin data device"
+		_notrun "failed to create dm thin data device"
 
 	# Zap the pool metadata dev.  Explicitly fsync the zeroes to disk
 	# because a slow-running udev running concurrently with dd can maintain
@@ -124,16 +124,16 @@ _dmthin_init()
 	# "start length thin-pool metadata_dev data_dev data_block_size low_water_mark"
 	DMTHIN_POOL_TABLE="0 $data_dev_size thin-pool $DMTHIN_META_DEV $DMTHIN_DATA_DEV $cluster_size $low_water"
 	_dmsetup_create $DMTHIN_POOL_NAME --table "$DMTHIN_POOL_TABLE" || \
-		_fatal "failed to create dm thin pool device"
+		_notun "failed to create dm thin pool device"
 
 	# Thin volume
 	$DMSETUP_PROG message $DMTHIN_POOL_DEV 0 "create_thin $pool_id" || \
-		_fatal "failed to message pool device"
+		_notrun "failed to message pool device"
 
 	# start length thin pool_dev dev_id [external_origin_dev]
 	DMTHIN_VOL_TABLE="0 $virtual_size thin $DMTHIN_POOL_DEV $pool_id"
 	_dmsetup_create $DMTHIN_VOL_NAME --table "$DMTHIN_VOL_TABLE" || \
-		_fatal "failed to create dm thin volume device"
+		_notrun "failed to create dm thin volume device"
 
 }
 
-- 
2.47.2





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux