https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx --- Comment #9 from Cristian Le <fedora@xxxxxxxxx> --- Please use a single repo and point the spec file to the github raw links for easier review, e.g. https://github.com/redadmin-k/gshogi-fedora44/raw/refs/heads/main/gshogi.spec There are quite a few issues here, and if you want it can be discussed more synchronously in the #devel chat room. - Source0 should point to the github source, unless it contains non-free files - Upstream is dead. If there are expected maintenance to be done, you better fork it, or research how other package ecosystems (e.g. Debian) are packaging this, if there are any - The summary and description could be better formulated - The project has a `setup.py`, please use it. See python packaging guidelines [1] - The header packaging is highly suspicious, let's revise it in light of the issue above - Python requires should be handled by the python buildsystem instead - There is some context that would be relevant to know regarding the relation between this project and `gnushogi`. Why would the user not run that directly? - The Version should point to the upstream's version. Release is used for downstream packaging only - The license is actually `GPL-3.0-or-later` according to the readme. Did you have anything else you were referencing that license from. We of course need to do a proper license review and find any potentially missing license [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
