https://bugzilla.redhat.com/show_bug.cgi?id=2388375 --- Comment #35 from Cristian Le <fedora@xxxxxxxxx> --- > - desktop-file-validate is now run at install. Please run it in %check like before > - The single-quoted RPM file names are display-only (no functional impact, safe to use). What is this a reference to? > - Removed all ez_setup related code and data_files from setup.py. Also `ez_setup.py` file itself. But I would encourage using a patch instead of sed. The latter can silently fail and is not as readable. Here is an example workflow for how to make patches ``` $ tar -xf /gshogi-*.tar.gz $ cp -r gshogi-* gshogi-*-new $ vi ghsogi-*-new/setup.py ... do your edits $ diff -ru gshogi-* gshogi-*-new > gshogi-my_patch.patch $ vi gshogi.spec ... Add it to `Patch:` and make sure you have `%autosetup` or equivalent to pull it in ``` > - Changed BuildRequires to use gtk3-devel instead of gtk3, and python3-gobject as required. Using ``` BuildRequires: pyproject-rpm-macros ``` is not supported. Please use `%pyproject_buildrequires`. If you have issues with it, let me know, there are a few modes it can operate. But as previously mentioned, it seemed to have built fine without `BuildRequires: gtk3-devel`. It is fairly odd, but I didn't dig into the sources to understand why. At least make the `BuildRequires` and `Requires` as minimal as it can be and comment on the manual additions. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c35 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
