https://bugzilla.redhat.com/show_bug.cgi?id=2388595 --- Comment #3 from Peter Oliver <mavit@xxxxxxxxxxxx> --- (In reply to Benson Muite from comment #2) > Comments: > a) Please use the %find_lang to find translations. See: > https://docs.fedoraproject.org/en-US/package-maintainers/ > Packaging_Tutorial_2_GNU_Hello/#_translations Done. > b) Your fork has probably diverged from > https://github.com/eonpatapon/mpDris2 > but maybe good to check for any conflicts Looks fine to me. > c) Consider using %forgesource macros: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > If not, please change > Source0: > %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz > to > Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz Done. > d) Please validate the desktop file > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files > > e) Please validate the appdata file > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ These are covered by `make test`. Thanks for looking at this. SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/slimpris2/fedora-rawhide-x86_64/09440531-slimpris2/slimpris2-4.0.0-1.20250818git4.0.0.fc44.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388595 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388595%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
