https://bugzilla.redhat.com/show_bug.cgi?id=2388595 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Comments: a) Please use the %find_lang to find translations. See: https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_2_GNU_Hello/#_translations b) Your fork has probably diverged from https://github.com/eonpatapon/mpDris2 but maybe good to check for any conflicts c) Consider using %forgesource macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ If not, please change Source0: %{url}/archive/refs/tags/%{version}.tar.gz#slimpris2-%{version}.tar.gz to Source0: %{url}/archive/%{version}/slimpris2-%{version}.tar.gz d) Please validate the desktop file https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files e) Please validate the appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388595 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388595%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
