https://bugzilla.redhat.com/show_bug.cgi?id=2387625 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #11 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review notes: There's a missing desktop-file-validate call in %check for installed .desktop file in %{_datadir}/applications. Also, one other piece... > %build > %meson -Dsystemd_user_unit_dir="%{_userunitdir}" This should be in %conf instead of %build unless you plan to build this for < EPEL 10. For an example, see: https://src.fedoraproject.org/rpms/wayback/blob/rawhide/f/wayback.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2387625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387625%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
