https://bugzilla.redhat.com/show_bug.cgi?id=2387625 Tomi Lähteenmäki <lihis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@xxxxxxxx | |m) --- Comment #12 from Tomi Lähteenmäki <lihis@xxxxxxxxx> --- Spec URL: https://codeberg.org/Lihis/cellbroadcastd-spec/raw/commit/89a6a05699cd79e7d0b49225f3c22eb774474d43/cellbroadcastd.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/990/136400990/cellbroadcastd-0.0.2-4.fc44.src.rpm > There's a missing desktop-file-validate call in %check for installed .desktop file in %{_datadir}/applications. Upstream tests [1] already validates it but added explicit check. > Also, one other piece... > > > %build > > %meson -Dsystemd_user_unit_dir="%{_userunitdir}" > > This should be in %conf instead of %build unless you plan to build this for < EPEL 10. > > For an example, see: https://src.fedoraproject.org/rpms/wayback/blob/rawhide/f/wayback.spec I see, thanks! I'll send a PR to update Packaging Guidelines for Meson as its example SPEC [2] does not contain %conf at all. [1] https://gitlab.freedesktop.org/devrtz/cellbroadcastd/-/blob/7229aad3bb60521a54c1c9a1abfaf4ecd8a1dd51/data/meson.build#L61 [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/#_example_rpm_spec_file -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2387625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387625%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
