https://bugzilla.redhat.com/show_bug.cgi?id=2388375 --- Comment #63 from Cristian Le <fedora@xxxxxxxxx> --- The patch looks better now. As a tip, keep the patch difference as minimal as possible so that it can be easily rebased (doesn't apply here, so do whatever). In your spec file you have > # No need to delete ez_setup.py, build/, dist/, *.egg-info here, > # because the tarball is already cleaned. Where did that come from? And I really mean, that I would like to know your thought process on this so we can find ways to better ways to guide you through typical packaging process and pitfalls you would encounter. Tarball cleaning is a **very** specialized tool and you **must** provide the script you have used to do the cleaning. This **should** only be done if there is really no other way around it, primarily free license violations. This does not apply here so **do not do it**. Furthermore the cleaning mentioned in the comment did not occur, `ez_setup.py` is still there. > To address your concerns, I performed the following steps to verify everything from scratch: > > 1 Extracted the SRPM's Source0 tarball. I did not ask you to do that, did I? If there is any part that were unclear in my comments **PLEASE TELL ME** so I can better formulate and make them clearer. If you feel more comfortable communicating in Japanese, let me know, my Japanese is nowhere near a native level, but I can understand it to some extents and I understand the intricacies of the grammar especially with respect to translations. This bugzilla bug would not be the best part to do so though because the official language is English here, but PM me on matrix and we can continue there however you feel more comfortable. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c63 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
