https://bugzilla.redhat.com/show_bug.cgi?id=2388375 --- Comment #64 from Akiyoshi Kurita <akito5623@xxxxxxxxx> --- Hi Cristian-san Thanks for the review and the guidance. On the “tarball cleaning” comment: That was my mistake. I did not perform any tarball cleaning, and that comment was misleading. I’ve removed it from the spec. I also understand that tarball cleaning is a very specialized process that requires a published script and a strong justification (e.g. license issues), which does not apply here. I will not do that. What I changed and why (minimal patch): I kept the patch as small as possible and limited it to setup.py only: Drop import ez_setup and the ez_setup.use_setuptools() call (they’re obsolete and unnecessary for pyproject/setuptools builds). Replace the dynamic data_files=[ … ] block with data_files=[] so that files are not installed outside the wheel. The .desktop file and icon are installed from the spec in %install, which is the distro-preferred way. I did not remove ez_setup.py from the source tree; it stays in the tarball, but it’s no longer referenced by setup.py. Spec updates: Removed the misleading comment about tarball cleaning. Kept %autosetup -p1 -n gshogi-%{commit} and pyproject macros. Continue to install the .desktop and icon via %install. If anything still looks off, I’m happy to adjust further. Thank you again for the detailed feedback! Best regards, Akiyoshi Kurita -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c64 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
