https://bugzilla.redhat.com/show_bug.cgi?id=2386109 Pavel Šimovec <psimovec@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review- --- Comment #1 from Pavel Šimovec <psimovec@xxxxxxxxxx> --- I see, that there are files with different licenses in the source, that just MIT. It would be good to either add them to license list, or at least giving comment/explanation why it is not necessary to add the licenses there. ___________ Optional: Latest package version is not packaged, but it's recent enough, that it's not a big deal. __________ I have tried building this package --with-check, the test were running, and then I started getting some 25 min timeouts, out of memory, etc.. But the tests are running, so I'd say the package works as expected. I stopped the build at this point. ... 2768/5096 Test #1057: Unit_hipMemPoolExportToShareableHandle_GrndChldUseHdl .......................................***Timeout 1500.10 sec Filters: Unit_hipMemPoolExportToShareableHandle_GrndChldUseHdl ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ MemoryTest1 is a Catch v2.13.4 host application. Run with -? for options ------------------------------------------------------------------------------- Unit_hipMemPoolExportToShareableHandle_GrndChldUseHdl ------------------------------------------------------------------------------- /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/unit/memory/hipMemPoolExportToShareableHandle.cc:351 ............................................................................... /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/unit/memory/hipMemPoolExportToShareableHandle.cc:431: FAILED: REQUIRE( false ) with message: Error: out of memory Code: 2 Str: hipMemPoolExportPointer(&ptrExp, A_d) In File: /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4. 2/catch/unit/memory/hipMemPoolExportToShareableHandle.cc At line: 431 =============================================================================== test cases: 1 | 1 failed assertions: 9 | 8 passed | 1 failed Start 2800: Unit_Thread_Block_Sync_Positive_Basic - uint8_t 2769/5096 Test #1969: Unit_hipGetProcAddress_IPC_Memory ...........................................................***Timeout 1500.03 sec Filters: Unit_hipGetProcAddress_IPC_Memory ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ DeviceTest is a Catch v2.13.4 host application. Run with -? for options ------------------------------------------------------------------------------- Unit_hipGetProcAddress_IPC_Memory ------------------------------------------------------------------------------- /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/unit/device/hipGetProcAddressIpcApis.cc:43 ............................................................................... /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/unit/device/hipGetProcAddressIpcApis.cc:78: FAILED: REQUIRE( false ) with message: Error: invalid argument Code: 1 Str: dyn_hipIpcGetMemHandle_ptr(&handle, devMemSrc) In File: /builddir/build/BUILD/hip-tests-6.4.2-build/hip-tests-rocm-6.4. 2/catch/unit/device/hipGetProcAddressIpcApis.cc At line: 78 =============================================================================== test cases: 1 | 1 failed assertions: 4 | 3 passed | 1 failed Start 2801: Unit_Thread_Block_Sync_Positive_Basic - uint16_t 2770/5096 Test #2678: Unit_hipStreamPerThreadTst_StrmQuery ........................................................***Timeout 1500.11 sec ... Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "BSD 2-Clause License", "Apache License 2.0". 132 files have unknown license. Detailed output of licensecheck in /home/psimovec/Downloads/hiptests/hip-tests/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4028 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: hip-tests-6.4.2-1.fc44.x86_64.rpm hip-tests-6.4.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8o3vdaot')] checks: 32, packages: 2 hip-tests.x86_64: W: unstripped-binary-or-object /usr/libexec/hip-tests/catch_tests/libLazyLoad.so 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 6.8 s Rpmlint (debuginfo) ------------------- Checking: hip-tests-debuginfo-6.4.2-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp68zr_8j6')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 161 filtered, 0 badness; has taken 16.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 hip-tests.x86_64: W: unused-direct-shlib-dependency /usr/libexec/hip-tests/catch_tests/GLInteropTest /lib64/ld-linux-x86-64.so.2 hip-tests.x86_64: W: unused-direct-shlib-dependency /usr/libexec/hip-tests/catch_tests/MathsTest /lib64/ld-linux-x86-64.so.2 hip-tests.x86_64: W: unused-direct-shlib-dependency /usr/libexec/hip-tests/catch_tests/libLazyLoad.so /lib64/libm.so.6 hip-tests.x86_64: W: unused-direct-shlib-dependency /usr/libexec/hip-tests/catch_tests/libLazyLoad.so /lib64/libgcc_s.so.1 hip-tests.x86_64: W: unstripped-binary-or-object /usr/libexec/hip-tests/catch_tests/libLazyLoad.so 2 packages and 0 specfiles checked; 0 errors, 5 warnings, 243 filtered, 0 badness; has taken 16.5 s Unversioned so-files -------------------- hip-tests: /usr/libexec/hip-tests/catch_tests/libLazyLoad.so Source checksums ---------------- https://github.com/ROCm/hip-tests/archive/rocm-6.4.2.tar.gz#/hip-tests-6.4.2.tar.gz : CHECKSUM(SHA256) this package : 8a39c8b9fa373636b86dd4c2df758a525de6772f27ee1e8e2c3d84c3f287532a CHECKSUM(SHA256) upstream package : 8a39c8b9fa373636b86dd4c2df758a525de6772f27ee1e8e2c3d84c3f287532a Requires -------- hip-tests (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libEGL.so.1()(64bit) libOpenGL.so.0()(64bit) libamdhip64.so.6()(64bit) libamdhip64.so.6(hip_4.2)(64bit) libamdhip64.so.6(hip_4.3)(64bit) libamdhip64.so.6(hip_4.4)(64bit) libamdhip64.so.6(hip_4.5)(64bit) libamdhip64.so.6(hip_5.0)(64bit) libamdhip64.so.6(hip_5.1)(64bit) libamdhip64.so.6(hip_5.2)(64bit) libamdhip64.so.6(hip_5.3)(64bit) libamdhip64.so.6(hip_5.5)(64bit) libamdhip64.so.6(hip_5.6)(64bit) libamdhip64.so.6(hip_6.0)(64bit) libamdhip64.so.6(hip_6.1)(64bit) libamdhip64.so.6(hip_6.2)(64bit) libamdhip64.so.6(hip_6.4)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_12.0.0)(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglut.so.3()(64bit) libhiprtc.so.6()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rocminfo Provides -------- hip-tests: hip-tests hip-tests(x86-64) libLazyLoad.so()(64bit) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --rpm-spec -n ./hip-tests-6.4.2-1.fc43.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, R, SugarActivity, Ocaml, Haskell, fonts, PHP, Perl, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386109%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
