https://bugzilla.redhat.com/show_bug.cgi?id=2386109 Tom.Rix@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(Tom.Rix@xxxxxxx) | --- Comment #2 from Tom.Rix@xxxxxxx --- Spec URL: https://trix.fedorapeople.org/hip-tests.spec SRPM URL: https://trix.fedorapeople.org/hip-tests-6.4.3-1.fc44.src.rpm > Optional: > Latest package version is not packaged, but it's recent enough, that it's not a big deal. Updated to 6.4.3 > I see, that there are files with different licenses in the source, that just MIT. It would be good to either add them to > license list, or at least giving comment/explanation why it is not necessary to add the licenses there. New line is License: MIT AND BSL-1.0 AND Apache-2.0 # The MIT License is the main license # The Boost Software License 1.0 is for the bundled catch2 # Apache 2.0 covers these files # catch/unit/math/math_special_values.hh # catch/unit/memory/hipSVMCommon.h # catch/unit/memory/hipSVMTestByteGranularity.cpp # catch/unit/memory/hipSVMTestFineGrainMemoryConsistency.cpp # catch/unit/memory/hipSVMTestFineGrainSyncBuffers.cpp # catch/unit/memory/hipSVMTestSharedAddressSpaceFineGrain.cp Some details BSD 2-Clause License -------------------- hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/external/picojson/LICENSE hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/external/picojson/picojson.h Removed # Remove local copy of picojson, use the system version rm -rf catch/external/picojson The use of the system picojson adds this and similar rpmlint errors hip-tests.x86_64: E: file-contains-date-and-time /usr/libexec/hip-tests/catch_tests/config/config_amd_linux_gfx1201.json I thought it is better to use the system picojson. Boost Software License 1.0 -------------------------- hip-tests-6.4.2-build/hip-tests-rocm-6.4.2/catch/external/Catch2/catch.hpp the system catch2 is 2.13.10, hip-tests' is older so I added this line # Boost Software License 1.0 # https://github.com/catchorg/Catch2/blob/v2.13.4/LICENSE.txt Provides: bundled(catch2) = 2.13.4 And these to use the license file # Rename the catch2 license so we can pick it up mv catch/external/Catch2/LICENSE.txt catch/external/Catch2/LICENSE.catch2.txt %license catch/external/Catch2/LICENSE.catch2.txt The apache 2's were misc files so i just listed them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2386109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386109%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
