https://bugzilla.redhat.com/show_bug.cgi?id=2386141 Pavel Šimovec <psimovec@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |psimovec@xxxxxxxxxx Flags| |fedora-review? | |needinfo?(Tom.Rix@xxxxxxx) Status|NEW |ASSIGNED CC| |psimovec@xxxxxxxxxx --- Comment #1 from Pavel Šimovec <psimovec@xxxxxxxxxx> --- [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. There is the problem with not-real license, but it's already fixed upstream. Using a630ec6965af237be71f6956dff4f62a43a9e7ab commit or later for this package will resolve the issue. https://github.com/pytorch/examples/issues/1378 [x]: Development files must be in a -devel package Automation complains about dev files not being -devel package, but this as this is package with examples, if the file cpp/transfer- learning/main.h is expected for the examples, then no problem. I wasn't 100% sure about expected usage of this package, none of the ways how I tried to use it seemed like the correct way. Could you please specify how the package is expected to be used? Below, I just mention what I have tried. ________________ I tried for example `python3 /usr/share/pytorch-examples/mnist/main.py --epochs 3 --no-accel` which worked, but without the --no-accel option, I got an error, even when I have installed rocm. ```File "/usr/share/pytorch-examples/mnist/main.py", line 141, in <module> main() ~~~~^^ File "/usr/share/pytorch-examples/mnist/main.py", line 97, in main use_accel = not args.no_accel and torch.accelerator.is_available() ^^^^^^^^^^^^^^^^^ File "/usr/lib64/python3.13/site-packages/torch/__init__.py", line 2562, in __getattr__ raise AttributeError(f"module '{__name__}' has no attribute '{name}'") AttributeError: module 'torch' has no attribute 'accelerator'``` ChatGPT gave me a workaround: ``` mkdir -p "$HOME/.ptex-shim" cat > "$HOME/.ptex-shim/sitecustomize.py" << 'EOF' import types, torch if not hasattr(torch, "accelerator"): torch.accelerator = types.SimpleNamespace( is_available=torch.cuda.is_available, current_accelerator=lambda: torch.device("cuda" if torch.cuda.is_available() else "cpu"), ) EOF ``` `PYTHONPATH="$HOME/.ptex-shim" python3 /usr/share/pytorch-examples/mnist/main.py --epochs 3` Which works and runs corrently on GPU, but I'd expect the example to just work out of the box when I just install python-examples and rocm. Then I tried time_sequence_prediction, there I had problem with permissions. When I copied the folder to a writable location, it worked. I also tried running run_python_examples.sh in userspace, some of the examples worked, but it was running in venv and re-downloading dependencies as torch that were already installed as a rpm dependecy. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: pytorch-examples : /usr/share/pytorch-examples/cpp/transfer- learning/main.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* MIT License", "Apache License". 219 files have unknown license. Detailed output of licensecheck in /home/psimovec/Downloads/pytorch- examples/review-pytorch-examples/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [?]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2608 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pytorch-examples-0.0^git20250727.e9a4e75-1.fc43.noarch.rpm pytorch-examples-0.0^git20250727.e9a4e75-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqujw_jwd')] checks: 32, packages: 2 pytorch-examples.spec: W: no-%check-section pytorch-examples.spec: W: no-%build-section pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/autograd/autograd.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/custom-dataset/custom-dataset.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/dcgan/dcgan.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/distributed/dist-mnist.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/mnist/mnist.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/regression/regression.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/classify.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/main.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/main.h pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/fx/native_interpreter/interpreter.cpp pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/distributed/minGPT-ddp/mingpt/slurm/config.yaml.template /usr/share/pytorch-examples/distributed/ddp-tutorial-series/slurm/config.yaml.template pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/distributed/rpc/rnn/requirements.txt /usr/share/pytorch-examples/distributed/rpc/parameter_server/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist_rnn/requirements.txt 2 packages and 0 specfiles checked; 0 errors, 24 warnings, 7 filtered, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/autograd/autograd.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/custom-dataset/custom-dataset.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/dcgan/dcgan.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/distributed/dist-mnist.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/mnist/mnist.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/regression/regression.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/classify.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/main.cpp pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/cpp/transfer-learning/main.h pytorch-examples.noarch: W: devel-file-in-non-devel-package /usr/share/pytorch-examples/fx/native_interpreter/interpreter.cpp pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/distributed/minGPT-ddp/mingpt/slurm/config.yaml.template /usr/share/pytorch-examples/distributed/ddp-tutorial-series/slurm/config.yaml.template pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/distributed/rpc/rnn/requirements.txt /usr/share/pytorch-examples/distributed/rpc/parameter_server/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/mnist_rnn/requirements.txt /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/fx/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist_forward_forward/requirements.txt pytorch-examples.noarch: W: cross-directory-hard-link /usr/share/pytorch-examples/siamese_network/requirements.txt /usr/share/pytorch-examples/mnist_rnn/requirements.txt 1 packages and 0 specfiles checked; 0 errors, 22 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/pytorch/examples/archive/e9a4e7510c89613a2fe75312fba1fb8c14b3b376/examples-e9a4e75.tar.gz : CHECKSUM(SHA256) this package : 78bd241a7e04b556ecef361ef4a1bd44835f1d6e729b74ccf58b16125323ac88 CHECKSUM(SHA256) upstream package : 78bd241a7e04b556ecef361ef4a1bd44835f1d6e729b74ccf58b16125323ac88 Requires -------- pytorch-examples (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/python3 python3dist(aiohttp) python3dist(boto3) python3dist(lmdb) python3dist(matplotlib) python3dist(numpy) python3dist(portalocker) python3dist(protobuf) python3dist(pygame) python3dist(requests) python3dist(sentencepiece) python3dist(six) python3dist(sphinx) python3dist(torch) python3dist(torchdata) python3dist(torchtext) python3dist(torchvision) python3dist(tqdm) Provides -------- pytorch-examples: pytorch-examples Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n pytorch-examples -m fedora-43-x86_64 -B -v Buildroot used: fedora-43-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, R, PHP, Haskell, fonts, SugarActivity, Java, Perl, C/C++, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2386141 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386141%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
