https://bugzilla.redhat.com/show_bug.cgi?id=2394940 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Not a full review, just a few quick initial observations: ---- In general, we “SHOULD NOT” package static libraries in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Is there a technical reason why the static (.a) libraries are absolutely necessary? If so, can you document it in the spec file? Otherwise, please pass -DSPIRV_CROSS_STATIC:BOOL=OFF to %cmake, disabling the static libraries. It looks like -DSPIRV_CROSS_STATIC:BOOL=OFF would keep you from building the CLI, so you might have to leave it enabled if you want the CLI. In that case, maybe you can just remove {_libdir}/pkgconfig/spirv-cross-c.pc and the static (.a) libraries after %cmake_install. ---- Is there a reason for this? # Remove cmake package files rm -r %{buildroot}/%{_datadir} Unless they are really broken, .cmake files are generally useful and desirable, sometimes necessary. ---- Please don’t glob across SONAME versions like this: %{_libdir}/libspirv-cross-c-shared.so* https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Instead, do something like this in %files libs: %{_libdir}/libspirv-cross-c-shared.so.0{,.*} …and put the unversioned .so link in the -devel package, NOT in -libs: %{_libdir}/libspirv-cross-c-shared.so See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages. ---- Since the -devel subpackage depends on the -libs subpackage, it doesn’t need its own copy of LICENSE. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2394940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394940%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
