https://bugzilla.redhat.com/show_bug.cgi?id=2395004 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. This appears to be fine. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Add some additional explanation of which license covers which paths. [!]: Development files must be in a -devel package This appears to be fine. [!]: Package is not known to require an ExcludeArch tag. Noting this does require x86_64 only. [x]: Package meets the Packaging Guidelines::Python Missed this. Good to go. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Link to bugs resolving the missing license files. [!]: Package does not include license text files separate from upstream. Should be included in the project upstream. [!]: Packages should try to preserve timestamps of original installed files. Add -p to your cp. python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi Does this need to be deleted? python-cupy.spec:108: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 108) Please resolve. python3-cupy.x86_64: E: devel-dependency hipblas-devel I think the note in the spec is good to cover this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2395004 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395004%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
