https://bugzilla.redhat.com/show_bug.cgi?id=2395004 --- Comment #4 from Tom.Rix@xxxxxxx --- Spec URL: https://trix.fedorapeople.org/python-cupy.spec SRPM URL: https://trix.fedorapeople.org/python-cupy-13.6.0-1.fc44.src.rpm For the update The changes >> [!]: If the package is under multiple licenses, the licensing breakdown >> must be documented in the spec. >> >> Add some additional explanation of which license covers which paths. The license tag is more explict now, I believe all the files in the license check are covered License: MIT AND BSD-3-Clause AND Apache-2.0 AND BSL-1.0 AND BSD-2-Clause # LICENSE : MIT # Is the main license for the project # # docs/source/license.rst # Is a attribution breakdown of where parts of the cupy project came from # NumPy - BSD-3-Clause # SciPy - BSD-3-Clause # cupyx/scipy/* # cuSignal - MIT # cupyx/signal/* # # LICENSE.thrust : Apache-2.0 AND BSL-1.0 AND BSD-2-Clause # Covers these files # cupy/_core/include/cupy/complex/* # # LICENSE.jitify : BSD-3-Clause # Covers this file # cupy/_core/include/cupy/_jitify/jitify.hpp # # LICENSE.random : BSD-3-Clause AND MIT # covers this file cupy/random/_kernels.py # # LICENSE.ndimage : MIT # covers cupyx/scipy/ndimage/cuda/*.h # # Misc file not covered by the LICENSE.* files # cupyx/scipy/special/_digamma.py BSL-1.0 # >> [!]: If the source package does not include license text(s) as a separate >> file from upstream, the packager SHOULD query upstream to include it. >> >> Link to bugs resolving the missing license files. The devel project does cover these license files, they are only missing from pypi. I improved the original comments and opened an issue upstream # Upstream for both of these license files # https://github.com/cupy/cupy/issues/9387 # # Files in _core/include/cupy/complex come from thrust # Here is its location in the devel project where thrust is a submodule # https://github.com/NVIDIA/cccl/blob/3a388b7b01512d48474b98389a3e776c8d8f817a/thrust/LICENSE Source1: LICENSE.thrust # The license listed from # cupy/random/_kernels.py # Here is its location in the devel project # https://github.com/cupy/cupy/blob/main/cupy/random/LICENSE Source2: LICENSE.random >> [!]: Packages should try to preserve timestamps of original installed >> files. >> >> Add -p to your cp. # Apache-2.0 AND BSL-1.0 AND BSD-2-Clause cp -p %{SOURCE1} LICENSE.thrust # BSD-3-Clause AND MIT cp -p %{SOURCE2} LICENSE.random >> python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi >> >> Does this need to be deleted? # python3-cupy.x86_64: E: zero-length /usr/lib64/python3.14/site-packages/cupy/_util.pyi %exclude %{python3_sitearch}/cupy/_util.pyi >> python-cupy.spec:108: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 108) >> >> Please resolve. Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2395004 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395004%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
