[Bug 2228190] Review Request: sugar-paint - Unretire package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2228190



--- Comment #16 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
1) To be able to install the desktop file, based on
https://github.com/sugarlabs/sugar-toolkit-gtk3/issues/453

please change
%{python3} setup.py install --prefix=%{buildroot}%{_prefix}
to
%{python3} setup.py install --destdir=%{buildroot} --prefix=%{_prefix}

please also change the last section of the spec file to:

%find_lang org.laptop.Oficina

%check
appstream-util validate-relax --nonet
%{buildroot}%{_metainfodir}/%{name}.metainfo.xml
desktop-file-validate
%{buildroot}%{_datadir}/applications/org.laptop.Oficina.activity.desktop

%files -f org.laptop.Oficina.lang
%license COPYING
%doc NEWS
%{python3_sitearch}/fill/
%{sugaractivitydir}/Paint.activity/
%{_datadir}/applications/org.laptop.Oficina.activity.desktop
%{_metainfodir}/sugar-paint.metainfo.xml


2) Please also remove the compiled .so files before creating the src.rpm
https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries

This assumes releases will continue to include pre-compiled library files.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2228190

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228190%23c16

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux