https://bugzilla.redhat.com/show_bug.cgi?id=2387518 Michael Catanzaro <mcatanza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? --- Comment #5 from Michael Catanzaro <mcatanza@xxxxxxxxxx> --- (In reply to Christian Hergert from comment #4) > LGPLv2.1+ is definitely the intended license. Anything that is not is an > accident. Thanks. eggbitset and timsort are both Apache-2.0, so you would need to remove them both if you want LGPLv2.1+ to be the only license. > I do want to suggest that things get broken up into the following: > > * "foundry" CLI tool (which statically links libfoundry) > * "libfoundry" and "libfoundry-devel" which is just the core API (e.g. no > GTK integration) > * "libfoundry-gtk" and "libfoundry-gtk-devel" which is the GTK integration Sounds reasonable. I doubt Fabio will object to that? This is a significant change, so I'll review this again after the subpackages have been added. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2387518 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387518%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue