https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #22 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > I have not found this policy in the Fedora golang packaging guidelines; please point me to it if I missed it. I think it's not clearly stated anywhere, so I opened a FESCo ticket for advice: https://pagure.io/fesco/issue/3464 > 1. Apply a patch to downgrade to go 1.24.4 instead of including the source for and building 1.24.6. As a result, it fails on fedora 41 but I just won't build it there. Should be OK after this update lands stable: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6ce837b350 But, can you enable F41 in your COPR to verify it better? > I couldn't use ${SOURCE_DATE_EPOCH} because it is not defined on el8, 9, or 10. It is only defined on Fedora. It's working fine for me in `gh` for EL9 & EL10. It may be missing for EL8. Can you use something like podman does like: LDFLAGS="-X %{ld_libpod}/define.buildInfo=${SOURCE_DATE_EPOCH:-$(date +%s)} \ > Thank you for all your comments, the spec file is much improved over it was. Agree, nice to see progress :) > Is anything else required? Yes, I think there a few other things to change. > %global go_version 1.24.6 This is a leftover > License: MPL-2.0 I think it should include the complete list of licenses as it's a vendored package. > BuildRequires: golang Should be golang-bin > Source0: https://github.com/opensciencegrid/%{name}-rpm/releases/download/v%{package_version}/%{name}-rpm-%{package_version}.tar.gz For what is this needed? If is to include different helper files, it would be better to list them individually and push them to dist-git rather than having an external repo > RPMDIR=$(pwd) is this a leftover? > uname_m=$(uname -m) same > %files > %files %{oldname}-compat Can these two blocks be the last blocks before %changelog block? I need to check applied Go flags, but will need more time for that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
