https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #17 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > %global go_version 1.24.6 > Source2: https://golang.org/dl/go%{go_version}.src.tar.gz > # put go src inside the above dir > %setup -q -D -T -a 2 -c -n %{name}-dist-%{package_version} Why is this needed for? You should use whatever Go version Fedora and EPEL ships, which might be different on each available release. This is a hard blocker. > Source0: https://github.com/opensciencegrid/%{name}-rpm/releases/download/v%{package_version}/%{name}-rpm-%{package_version}.tar.gz Is this required anymore? > if [ "$uname_m" = ppc64le ]; then > GO_BUILD_MODE="-buildmode default" > else > GO_BUILD_MODE="-buildmode pie" > fi What's the problem with ppc64le? > BUILD_DATE="$(date --utc +%Y-%m-%dT%H:%M:%SZ)" You can use: $(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d) > # These are from the %%gobuild macro which we can't use because it doesn't > # allow for extra tags (nor extra gcflags for debug mode). > GO_BUILD_TAGS+=" rpm_crashtraceback libtrust_openssl" > GO_BUILD_LDFLAGS+=" -linkmode=external -compressdwarf=false" > GO_BUILD_LDFLAGS+=" -extldflags '%__global_ldflags'" > > %if "%{?go_debug}" != "" > # add debugging & testing flags > GO_BUILD_GCFLAGS="all=-N -l" > GO_BUILD_LDFLAGS+=" -X github.com/%{name}/%{name}/version.VersionMetadata=testonly" > # openbao documentation says testonly should not be used for production builds > GO_BUILD_TAGS+=" testonly" > %endif Do you plan to build debug builds for Fedora or EPEL? I don't think they belong here. > %if "%{?osg}" != "" here are multiple entries like this. Same thing, not sure if they should belong here for Fedora & EPEL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
