https://bugzilla.redhat.com/show_bug.cgi?id=2376217 --- Comment #18 from Dave Dykstra <dwd@xxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #17) > > %global go_version 1.24.6 > > Source2: https://golang.org/dl/go%{go_version}.src.tar.gz > > # put go src inside the above dir > > %setup -q -D -T -a 2 -c -n %{name}-dist-%{package_version} > > Why is this needed for? > > You should use whatever Go version Fedora and EPEL ships, which might be > different on each available release. This is a hard blocker. The upstream openbao requires a newer version of Go than is currently shipped in EPEL and I believe Fedora although maybe not the latest version of Fedora. Every release they update to the latest one. The build step compiles the required version of go using the OS version. Go keeps making it harder to continue to use an older version by continually updating the version required in go.mod so I don't see a way around this. I could have it check to see if the current version is new enough and skip the build. (We can't include a go binary instead because that only works on one architecture.) > > Source0: https://github.com/opensciencegrid/%{name}-rpm/releases/download/v%{package_version}/%{name}-rpm-%{package_version}.tar.gz > > Is this required anymore? The way that it is currently done, yes. Is it a problem? It would be possible to individually add all the extra files instead if necessary but this is easier. > > if [ "$uname_m" = ppc64le ]; then > > GO_BUILD_MODE="-buildmode default" > > else > > GO_BUILD_MODE="-buildmode pie" > > fi > > What's the problem with ppc64le? I didn't actually verify it, but that was what was done for the apptainer build in EPEL for some reason, so I followed what it did. I assumed the %gobuild macro which we can't use does it differently on ppc64le. > > BUILD_DATE="$(date --utc +%Y-%m-%dT%H:%M:%SZ)" > > You can use: > > $(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%d) Ok I'll try that. > > # These are from the %%gobuild macro which we can't use because it doesn't > > # allow for extra tags (nor extra gcflags for debug mode). > > GO_BUILD_TAGS+=" rpm_crashtraceback libtrust_openssl" > > GO_BUILD_LDFLAGS+=" -linkmode=external -compressdwarf=false" > > GO_BUILD_LDFLAGS+=" -extldflags '%__global_ldflags'" > > > > %if "%{?go_debug}" != "" > > # add debugging & testing flags > > GO_BUILD_GCFLAGS="all=-N -l" > > GO_BUILD_LDFLAGS+=" -X github.com/%{name}/%{name}/version.VersionMetadata=testonly" > > # openbao documentation says testonly should not be used for production builds > > GO_BUILD_TAGS+=" testonly" > > %endif > > Do you plan to build debug builds for Fedora or EPEL? I don't think they > belong here. Not for Fedora or EPEL, but the same .spec file is used for development so I'd rather leave it in. People can rebuild the src rpm with the extra option if they need to do debugging. > > %if "%{?osg}" != "" > > here are multiple entries like this. Same thing, not sure if they should > belong here for Fedora & EPEL. As I said above, I will remove those before final submittal. Please disregard them. They were just there for my convenience until I build the last openbao transitioning rpm outside of EPEL. I'm actually currently working on doing that transition build so I could probably remove this soon. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2376217 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202376217%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
