[Bug 2353869] Review Request: libmbd - Many-body dispersion library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2353869



--- Comment #18 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
(In reply to Cristian Le from comment #17)
> > What is the source of vdw-params.csv ?
> 
> I had comments in the spec file about it, and I opened an upstream issue to
> get clarification about it. The earliest reference to it is here [1], but
> also there there is no clear note on where this comes from.

Until this is resolved, remove the file from the sources before creating a
source rpm, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code

> 
> > Additionally, mpi4py in Fedora can come from either python3-mpi4py-openmpi or python3-mpi4py-mpich
> 
> This should not be an issue if the `PYTHONPATH` is adjusted during the
> module load. I did a quick check and I've found that that is not the case.
> But this is an issue we should address in the mpi4py package. Do you want to
> open an issue about it and maybe we can work on that.

This does not block the current review, will raise issue for mpi4py.
> 
> > Main problem is that some work is required for numpy>2 compatibility.
> 
> Well, great, that seems like it will be a fun journey. Seems like it will
> take some time to even get a communication channel with them about these
> issues.

Does not block the current review, but you may want to note it in the spec file
as something blocking inclusion of the Python package in addition to the
licensing
issue.

> 
> [1]:
> https://github.com/libmbd/libmbd/commit/
> cfdcb29fe136b3c1e35fbe224224f9713f27f37c


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2353869

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353869%23c18

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux