https://bugzilla.redhat.com/show_bug.cgi?id=2369466 --- Comment #32 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Jarek Prokop from comment #30) > Considering the unit testing part is quite new to node IIRC, it's not > blocking (seems the test-should-pass.txt is much bigger than that list of > not found so I'm assuming it ran properly) so I'd consider it "cosmetic > issue", but there is following in build log: > > ``` > + bash /builddir/build/SOURCES/test-runner.sh > /builddir/build/BUILD/nodejs24-24.0.1-build/BUILDROOT/usr/bin/node-24 test/ > /builddir/build/SOURCES/test-should-pass.txt > Started test run: > Test script not found: test//es-module/test-require-module-tla.js > ... > ``` The test-should-pass.txt was taken directly from nodejs22 and not adjusted, due to the slew of other necessary changes. We'll adjust this in the near future. > Package Approved! Thanks, importing now! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2369466 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202369466%23c32 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
