https://bugzilla.redhat.com/show_bug.cgi?id=2367699 --- Comment #3 from Emmanuel Seyman <emmanuel@xxxxxxxxx> --- (In reply to Michael S. from comment #2) > > So, it seems there is no packaging policy for ansible-role, I think this > could be a opportunity to add one. the only example I found of reviewed > ansible role were in openstack so I will take a look at them. FTR, I have quite a few packages coming. > - there is requirements I have added ansible-core, ansible-collection-ansible-posix and ansible-collection-community-general as requirements. Spec URL: https://eseyman.fedorapeople.org/ansible-role-robertdebock-users/ansible-role-robertdebock-users.spec SRPM URL: https://eseyman.fedorapeople.org/ansible-role-robertdebock-users/ansible-role-robertdebock-users-6.1.5-2.fc42.src.rpm > - there is molecule tests, so I think there should be a attempt to run > molecule in %check, especially since Fedora use python version that are not > tested upstream, this might break. While I'm not scared of breakage (upstream does CI against Fedora), running molecule does seem to be a good idea, if possible. > - if I am not wrong, we need to add explicit dependencies and no longer rely > , and so we might need openssh (for ssh-keygen), shadow-utils (for chage), > sudo (for visudo, used to validate config) and gawk (for awk). Not sure the > exact policy nowadays. If I'm not mistaken, these are used on the managed node, not the control node. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2367699 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367699%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
