https://bugzilla.redhat.com/show_bug.cgi?id=2367699 Michael S. <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #2 from Michael S. <misc@xxxxxxxx> --- So, it seems there is no packaging policy for ansible-role, I think this could be a opportunity to add one. the only example I found of reviewed ansible role were in openstack so I will take a look at them. However, in the mean time, I have a few comments (not looked in detail yet at the fedora-review output): - there is requirements (https://github.com/robertdebock/ansible-role-users/blob/master/requirements.yml) that seems to be missing, and also in the requirements.txt for python requirements. I think the .txt are not needed for run time for now, the 2 roles (bootstrap and core_dependencies) might not be strictly required. However, the collections ones might be important and I think this should be expressed in Requirements (we have a rpm for ansible-collection-community-general.noarch, not sure that's pulled by existing deps, and I think it could be automated). - there is molecule tests, so I think there should be a attempt to run molecule in %check, especially since Fedora use python version that are not tested upstream, this might break. - if I am not wrong, we need to add explicit dependencies and no longer rely , and so we might need openssh (for ssh-keygen), shadow-utils (for chage), sudo (for visudo, used to validate config) and gawk (for awk). Not sure the exact policy nowadays. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2367699 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202367699%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
