https://bugzilla.redhat.com/show_bug.cgi?id=2371328 --- Comment #19 from Claire Robsahm <inquiries@xxxxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #18) > Please sort BuildRequires: alphabetically. > > > Requires: mesa-libGL > > Can you justify this? I switched from building with Ogre to building with openGL. I'm not sure if openGL comes with Fedora, or if this is the right package to require for openGL compatibility. Let me know. > rpmbuild already generates: > Requires: libOpenGL.so.0()(64bit) > > > Requires: sdl2-compat > > This is redundant, because rpmbuild already generates: > Requires: libSDL2-2.0.so.0()(64bit) Will remove it. > > install -m 0755 %{SOURCE2} %{buildroot}%{_bindir}/MyGUI-Tools > > The above should include the -p argument to preserve the timestamp of the > source file for reproducibility. Understood. > > Requires: pkgconfig, ois-devel, mesa-libGL-devel > > Please split into separate lines and sort alphabetically. Will do. > > %cmake -G Ninja \ > > -DMYGUI_INSTALL_PDB=FALSE -DMYGUI_BUILD_DEMOS=FALSE -DMYGUI_BUILD_PLUGINS=OFF \ > > -DMYGUI_DONT_USE_OBSOLETE=ON -DMYGUI_BUILD_TOOLS=TRUE -DMYGUI_USE_SYSTEM_GLEW=TRUE \ > > -DMYGUI_RENDERSYSTEM=4 -DMYGUI_INSTALL_TOOLS=TRUE -DMYGUI_BUILD_DOCS=TRUE -DMYGUI_INSTALL_DOCS=TRUE \ > > -DMYGUI_INSTALL_DEMOS=FALSE > > I recommend putting each CMake option in a separate line and sorting > alphabetically for readability. Makes sense. > > > cd %{_vpath_builddir} > > pushd Docs > > doxygen > > popd > > Is that the recommended upstream way of building docs? Docs/CMakeLists.txt > seems to have "api-docs" target, so you should be able to run it. This is how the old package did it, so I was just reimplementing that because I couldn't get the docs to build properly using the CMAKE target. > > %{_libdir}/*.so.* > > This must be explicitly listed to avoid accidental SONAME bumps. Will do. > > %files devel > > %{_includedir}/* > > %{_libdir}/*.so > > %{_libdir}/pkgconfig/*.pc > > These should be listed explicitly as well. Please avoid using wildcards as > much as possible. It's a lot of files to list, but I'll go through them all appropriately. > > %{_iconsdir}/hicolor > > Same here. Please use something like: > %{_iconsdir}/hicolor/*/apps/mygui_*.png Thank you for all of the feedback. I can't quite make changes right now, but I wanted to update you that I had seen it (and ask my openGL question!). I'll probably make the necessary changes tonight or tomorrow -- I have a dayjob that's requiring a bit of my attention recently, but I promise to get to it ASAP! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2371328 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371328%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
