https://bugzilla.redhat.com/show_bug.cgi?id=2371328 --- Comment #18 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Please sort BuildRequires: alphabetically. > Requires: mesa-libGL Can you justify this? rpmbuild already generates: Requires: libOpenGL.so.0()(64bit) > Requires: sdl2-compat This is redundant, because rpmbuild already generates: Requires: libSDL2-2.0.so.0()(64bit) > install -m 0755 %{SOURCE2} %{buildroot}%{_bindir}/MyGUI-Tools The above should include the -p argument to preserve the timestamp of the source file for reproducibility. > Requires: pkgconfig, ois-devel, mesa-libGL-devel Please split into separate lines and sort alphabetically. > %cmake -G Ninja \ > -DMYGUI_INSTALL_PDB=FALSE -DMYGUI_BUILD_DEMOS=FALSE -DMYGUI_BUILD_PLUGINS=OFF \ > -DMYGUI_DONT_USE_OBSOLETE=ON -DMYGUI_BUILD_TOOLS=TRUE -DMYGUI_USE_SYSTEM_GLEW=TRUE \ > -DMYGUI_RENDERSYSTEM=4 -DMYGUI_INSTALL_TOOLS=TRUE -DMYGUI_BUILD_DOCS=TRUE -DMYGUI_INSTALL_DOCS=TRUE \ > -DMYGUI_INSTALL_DEMOS=FALSE I recommend putting each CMake option in a separate line and sorting alphabetically for readability. > cd %{_vpath_builddir} > pushd Docs > doxygen > popd Is that the recommended upstream way of building docs? Docs/CMakeLists.txt seems to have "api-docs" target, so you should be able to run it. > %{_libdir}/*.so.* This must be explicitly listed to avoid accidental SONAME bumps. > %files devel > %{_includedir}/* > %{_libdir}/*.so > %{_libdir}/pkgconfig/*.pc These should be listed explicitly as well. Please avoid using wildcards as much as possible. > %{_iconsdir}/hicolor Same here. Please use something like: %{_iconsdir}/hicolor/*/apps/mygui_*.png -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2371328 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371328%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
