https://bugzilla.redhat.com/show_bug.cgi?id=2360119 --- Comment #27 from Gerd Hoffmann <kraxel@xxxxxxxxxx> --- > Additionally, it's a bit jarring that the definition of the > %{name}-%{efiarch} subpackage happens between metadata for the "main" > package and the definition of the %descripion for the "main" package. I > would suggest to move the subpackage definition *below* the %description for > the "main" package for clarity (even if that might mean having the "%if > %{with efi_apps}" conditional in two places). rpm is a bit picky where it allows %description being placed. Placing it before the sub-rpm definition did not work for me. Placing it before the sub-rpm %description worked, and yes, that needs the condition twice. Phew. Took me a while to make that build. > > libefi has a module which uses udev. Both binaries use the library > > but not the module. Apparently rust links in libudev nevertheless. > > I don't understand the distinction between "module" and "library" here. As defined by rust. 'library' is lib.rs and everything included by it. 'module' is one 'pub mod $name;'. Specifically the efifile.rs module uses udev, the other modules in the library do not. > But > if the Rust crate uses pkg-config to probe for libudev, then that gets an > "-ludev" argument unconditionally from the pkg-config file from > systemd-devel. spec url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09203447-virt-firmware-rs/virt-firmware-rs.spec srpm url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/09203447-virt-firmware-rs/virt-firmware-rs-25.6-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c27 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
