https://bugzilla.redhat.com/show_bug.cgi?id=2360119 --- Comment #26 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the update - some more comments: 1) The Summary and %description are nice now, there's just a typo in the Summary ("firmwarea") Additionally, it's a bit jarring that the definition of the %{name}-%{efiarch} subpackage happens between metadata for the "main" package and the definition of the %descripion for the "main" package. I would suggest to move the subpackage definition *below* the %description for the "main" package for clarity (even if that might mean having the "%if %{with efi_apps}" conditional in two places). 2) You generate the list of statically linked dependencies with "%{cargo_license} > LICENSE.dependencies" but then don't use that file anywhere. You'll need to include it as "%license LICENSE.dependencies" in both %files lists. 3) The statically linked dependencies need to be reflected in the License tag as well. I would suggest moving "MIT" to the "SourceLicense" tag, and use the output of %cargo_license_summary for populating the License tag (the "%shrink" macro can help so you don't end up with a really long line that is hard to maintain and keep up-to-date): ``` SourceLicense: MIT # Apache-2.0 # Apache-2.0 OR BSL-1.0 # Apache-2.0 OR MIT # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # MIT # MIT OR Apache-2.0 # MPL-2.0 # Unlicense OR MIT License: %{shrink: MIT AND Apache-2.0 AND MPL-2.0 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (Unlicense OR MIT) } ``` PS: > libefi has a module which uses udev. Both binaries use the library > but not the module. Apparently rust links in libudev nevertheless. I don't understand the distinction between "module" and "library" here. But if the Rust crate uses pkg-config to probe for libudev, then that gets an "-ludev" argument unconditionally from the pkg-config file from systemd-devel. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c26 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
