[Bug 2356980] Review Request: rauc - Safe and secure software updates for embedded Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2356980



--- Comment #41 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---


Comments:
a) man page should not be marked as doc, just use
 %{_mandir}/man1/rauc.1.*
b) There are a number of tools to convert from svg to png, see for example:
https://stackoverflow.com/questions/9853325/how-to-convert-a-svg-to-a-png-with-imagemagick#14174624
inkscape, lunasvg and thorvg provide such tools.  One could add a build
requires on one of these. The
example below is for thorvg, in the build section, modify

pushd docs
sphinx-build . texinfo -b texinfo

to

pushd docs
pushd images
tvg_svg2png .
popd
sed -i "s/\.svg/\.png/g" *.rst
tvg_svg2png RAUC_Logo_outline.svg
sed -i "s/html_logo = 'RAUC_Logo_outline.svg'/html_logo =
'RAUC_Logo_outline.png'/g" conf.py
sphinx-build . texinfo -b texinfo


You could also create a patch instead of using sed.

b) For me to sponsor you, please do mock reviews of three packages that are
currently open for
import into Fedora and link to them here.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2356980

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202356980%23c41

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux