https://bugzilla.redhat.com/show_bug.cgi?id=2358542 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Alexander Lent from comment #5) > Hi, thanks for claiming this review! I'll try to get a revised package out > soon for this one as well. > > (That said, I think Comment 4 belongs to bug 2369375.) Indeed, thanks. Here’s what I meant to post: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/macro_rules_attribute-0.2.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not a serious problem; due to a reasonable rust2rpm design decision. - The Cargo.toml patch changing the license expression *really* needs an explanatory comment and upstream status. In bug 2358541 for rust-macro_rules_attribute-proc_macro, you added: # * License metadata was incorrect, see maintainer-accepted patch # * https://github.com/danielhenrymantilla/macro_rules_attribute-rs/commit/ddcf04f30717c80a37911cb311dac5dc20c35ae6 # * and the fix for the subpackage # * https://github.com/danielhenrymantilla/macro_rules_attribute-rs/pull/28 For this package, you can add: # * License metadata was incorrect, see maintainer-accepted patch # * https://github.com/danielhenrymantilla/macro_rules_attribute-rs/commit/ddcf04f30717c80a37911cb311dac5dc20c35ae6 - Please exclude the maintainer shell scripts from the crate to avoid generating an unnecessary dependency on /usr/bin/sh in rust-macro_rules_attribute-devel. (I know there will always be a POSIX shell installed in the buildroot, but it’s still right in principle to minimize dependencies.) Since these are not useful to anyone for building the crate, I suggested the change upstream in https://github.com/danielhenrymantilla/macro_rules_attribute-rs/pull/29. You can consult that PR for the necessary Cargo.toml line, and you should link it in your patch comment to provide upstream status for the change. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "zlib License". 13 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2358542-rust- macro_rules_attribute/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- macro_rules_attribute-devel , rust-macro_rules_attribute+default-devel , rust-macro_rules_attribute+better-docs-devel , rust- macro_rules_attribute+verbose-expansions-devel [x]: Package functions as described. (Tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. License metadata patch is correct but needs status/justification. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. I did not bother checking this, as it would have required a COPR build with rust-macro_rules_attribute-proc_macro. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-macro_rules_attribute-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute+default-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute+better-docs-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute+verbose-expansions-devel-0.2.0-1.fc43.noarch.rpm rust-macro_rules_attribute-0.2.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppfabijyo')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 25 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 21 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/macro_rules_attribute/0.2.0/download#/macro_rules_attribute-0.2.0.crate : CHECKSUM(SHA256) this package : 8a82271f7bc033d84bbca59a3ce3e4159938cb08a9c3aebbe54d215131518a13 CHECKSUM(SHA256) upstream package : 8a82271f7bc033d84bbca59a3ce3e4159938cb08a9c3aebbe54d215131518a13 Requires -------- rust-macro_rules_attribute-devel (rpmlib, GLIBC filtered): (crate(macro_rules_attribute-proc_macro/default) >= 0.2.0 with crate(macro_rules_attribute-proc_macro/default) < 0.3.0~) (crate(paste/default) >= 1.0.7 with crate(paste/default) < 2.0.0~) /usr/bin/sh cargo rust-macro_rules_attribute+default-devel (rpmlib, GLIBC filtered): cargo crate(macro_rules_attribute) rust-macro_rules_attribute+better-docs-devel (rpmlib, GLIBC filtered): cargo crate(macro_rules_attribute) rust-macro_rules_attribute+verbose-expansions-devel (rpmlib, GLIBC filtered): (crate(macro_rules_attribute-proc_macro/verbose-expansions) >= 0.2.0 with crate(macro_rules_attribute-proc_macro/verbose-expansions) < 0.3.0~) cargo crate(macro_rules_attribute) Provides -------- rust-macro_rules_attribute-devel: crate(macro_rules_attribute) rust-macro_rules_attribute-devel rust-macro_rules_attribute+default-devel: crate(macro_rules_attribute/default) rust-macro_rules_attribute+default-devel rust-macro_rules_attribute+better-docs-devel: crate(macro_rules_attribute/better-docs) rust-macro_rules_attribute+better-docs-devel rust-macro_rules_attribute+verbose-expansions-devel: crate(macro_rules_attribute/verbose-expansions) rust-macro_rules_attribute+verbose-expansions-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -L mra_deps/ -b 2358542 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, SugarActivity, Ocaml, Perl, fonts, Haskell, PHP, Python, C/C++, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Built with local dependencies: /home/ben/fedora/review/mra_deps/rust-macro_rules_attribute-proc_macro+default-devel-0.2.0-1.fc43.noarch.rpm /home/ben/fedora/review/mra_deps/rust-macro_rules_attribute-proc_macro-devel-0.2.0-1.fc43.noarch.rpm /home/ben/fedora/review/mra_deps/rust-macro_rules_attribute-proc_macro+verbose-expansions-devel-0.2.0-1.fc43.noarch.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358542 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358542%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
