[Bug 2368737] Review Request: cef - Chromium Embedded Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2368737



--- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> ---
This package is essentially forked from Chromium with the CEF bits merged in.

Review notes:

* Package generally follows Fedora Packaging Guidelines
* Licensing is the same as Chromium so looks good there
* Package builds and installs locally (verified aarch64)
* Generated mutually exclusive subpackages have correct dependencies, but the
RemovePathPostfixes doesn't seem to have worked.
  - Examining the generated spec makes me think it's not used correctly

Are you sure "${postfix:+RemovePathPostfixes: }${postfix}" is correct?

For "cef-api13301-devel", I would expect "RemovePathPostfixes: .api13301/" as
the string to "strip".


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2368737

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368737%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux