https://bugzilla.redhat.com/show_bug.cgi?id=2368625 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rlandman@xxxxxxxxxx Flags| |needinfo?(rlandman@redhat.c | |om) --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Cristian Le from comment #2) > - About test requirements, could you eliminate the `black`, > `beautifulsoup4`, `coverage` tests and dependencies. Most likely these tests > would not be run downstream either, and I am not sure how much you want to > burden yourself with maintaining that part. Done > - About documentation, I believe the install location is not distro > friendly? Could you move them to `%_pkgdocdir`, but also This is mostly for README, AUTHORS, Changelog and other similar files. Documentation files for yelp go in %{_datadir}/help/ and then the appropriate language folder. Checking with Rüdiger Landmann who know about DocBook from maintaining Publican https://src.fedoraproject.org/rpms/publican Though may also need to ask on list. > - Do you really need/want to package the documentations. Especially for a > project like this that would not have a user-facing audience Helpful. Sometimes one is offline and wants documentation. > - The fact that `test_nb_regression` is failing, is quite telling. I think > it would be cleaner to just ignore them altogether. Helps verify functionality. > Btw, nice bash-foo > syntax on that Not mine. Stolen from Ben Beasley. > - I know upstream has quite a lot on his plate, but if you could coordinate > and merge (as in squash) some of the open PRs, that would make it easier for > him to catch up with this Not a good fit for me. Rarely use Python notebooks. If there are other things in HPC/Materials Science that could be useful, happy to help with those. Can also update pyproject.toml > - Could you add `README.md` to `%doc`? I am not aware of it being added > automatically from `%pyproject_wheel` (though would be nice if it was) Done > - The "Remove coverage from tests" could you make them a patch instead? > `sed` would not catch if the original source has changed, but the latter > would. Done spec: https://fed500.fedorapeople.org/python-pytest-notebook.spec srpm: https://fed500.fedorapeople.org/python-pytest-notebook-0.10.0-1.fc41~bootstrap.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2368625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368625%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
