https://bugzilla.redhat.com/show_bug.cgi?id=2368625 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxx --- Comment #2 from Cristian Le <fedora@xxxxxxxxx> --- - About test requirements, could you eliminate the `black`, `beautifulsoup4`, `coverage` tests and dependencies. Most likely these tests would not be run downstream either, and I am not sure how much you want to burden yourself with maintaining that part. - About documentation, I believe the install location is not distro friendly? Could you move them to `%_pkgdocdir`, but also - Do you really need/want to package the documentations. Especially for a project like this that would not have a user-facing audience - The fact that `test_nb_regression` is failing, is quite telling. I think it would be cleaner to just ignore them altogether. Btw, nice bash-foo syntax on that - I know upstream has quite a lot on his plate, but if you could coordinate and merge (as in squash) some of the open PRs, that would make it easier for him to catch up with this - Could you add `README.md` to `%doc`? I am not aware of it being added automatically from `%pyproject_wheel` (though would be nice if it was) - The "Remove coverage from tests" could you make them a patch instead? `sed` would not catch if the original source has changed, but the latter would. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2368625 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202368625%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
