https://bugzilla.redhat.com/show_bug.cgi?id=2363087 --- Comment #22 from Elaine Gibson <ypsvlq@xxxxxxxxx> --- (In reply to Benson Muite from comment #21) > b) Can tests be built and run? Not currently, fixes have been sent upstream, will enable them when possible. https://github.com/fooyin/fooyin/pull/524 > c) May want to add sdl2-compat-devel as a dependency I left it out initially as ALSA+PipeWire seemed complete, no reason not to include it though. > d) Is it worth packaging libvgm: libvgm code is a mix of GPL, various BSD, and in some places no clear license (and doesn't make releases), definitely prevents packaging/bundling it. https://github.com/ValleyBell/libvgm/issues/43 https://github.com/ValleyBell/libvgm/issues/129 > Does not block the review, but if not, may want to add > -DBUILD_LIBVGM=OFF > to cmake build flags as it is not currently bundled. Agreed. > e) Upstream has a Fedora build: > https://github.com/fooyin/fooyin/blob/master/.github/workflows/build.yml#L40 > may want to check if they would be willing to use https://packit.dev as > it would simplify maintenance. I think the main developer is currently busy with other things, but definitely something to look at, thanks. > f) None of the above are blocking for approving the package. b would be nice > if possible. Thanks for the review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363087%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
