https://bugzilla.redhat.com/show_bug.cgi?id=2361600 --- Comment #7 from Luigi Leonardi <leonardi@xxxxxxxxxx> --- Hi Cole and Daniel, > So I think this package should be called `igvm`. Should I create a new ticket or just rename this one? > rust-bitfield-struct is at version 0.11 in Fedora, so you need to adjust your version patch. I confirmed it's still building with that good catch, thanks for checking! > take a look at /usr/lib/rpm/macros.d/macros.cargo %__cargo macro. I think you want to export `CARGO_HOME=.cargo` and `RUSTFLAGS='%{build_rustflags}'` too so that trickles down to cargo called by the Makefile. good point, will do! > What does the 'avoid-dev-deps' flag skip ? It's a flag it's normally used by %cargo_build (it's in __cargo_common_opts) but yes, it's useless in this case since there are no dev-dependencies. I can drop RUSTC_BOOTSTRAP too. > Is that needed ? If building locally you can give an arg to RPM to skip checks. If building in Fedora I'd expects checks to always be run & passing It's from the default cargo2rpm template but I can drop it. > The src.rpm has gone, and the only build I see in copr has a spec file that is different from the above one, so I'm unclear as to what this ticket should be reviewing as the "latest". Where can I upload the file so that it's not removed after a while? > Seems like upstream should define a top level target 'build' and have 'all' depend on 'build' + 'test'. I'll send a PR upstream So to recap, I need to create a `igvm-devel` package that contains .a and headers etc and a `igmm-tool` just with the `dump_igvm`? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202361600%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
