https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Daniel Berrangé <berrange@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(berrange@redhat.c | |om) | --- Comment #6 from Daniel Berrangé <berrange@xxxxxxxxxx> --- > But since libigvm doesn't have .so files at all, `libigvm` doesn't exist, and `libigvm-devel` on its own is pointless. > So I _think_ this should stuff pkgconfig and /usr/include bits into libigvm-static, and kill the libigvm-devel package too. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries Says that for the "static only" case don't create a -static, put the .a file in the -devel + if the dump_igvm tool is just a helper tool, I think it should go in a `NAME-tools` package Agreed > Spec URL: https://gitlab.com/luigileonardi/libigvm/-/raw/no_vendor/libigvm.spec > SRPM URL: https://download.copr.fedorainfracloud.org/results/lleonard/sev-snp-coconut/fedora-rawhide-x86_64/08918482-libigvm/libigvm-0.3.4-1.fc43.src.rpm The src.rpm has gone, and the only build I see in copr has a spec file that is different from the above one, so I'm unclear as to what this ticket should be reviewing as the "latest". > export EXTRA_PARAMS="--profile rpm -Z avoid-dev-deps" What does the 'avoid-dev-deps' flag skip ? > # Run test just when necessary. This is not upstream > Patch6: 0007-Remove-test-from-all-target.patch Seems like upstream should define a top level target 'build' and have 'all' depend on 'build' + 'test'. > %if %{with check} Is that needed ? If building locally you can give an arg to RPM to skip checks. If building in Fedora I'd expects checks to always be run & passing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2361600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202361600%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
