https://bugzilla.redhat.com/show_bug.cgi?id=2358524 --- Comment #4 from Alexander Lent <lx@xxxxxxxxxxxxxx> --- Spec URL: https://gist.githubusercontent.com/xanderlent/bb2e75d150686c1b54880d1258bb5d81/raw/f34e107e73eb67db00231e9c6547467de88ba0df/rust-spm_precompiled.spec SRPM URL: https://gist.github.com/xanderlent/bb2e75d150686c1b54880d1258bb5d81/raw/f34e107e73eb67db00231e9c6547467de88ba0df/rust-spm_precompiled-0.1.4-1.fc43.src.rpm Thanks for the review! This is definitely an unusual package. 1. I've tried to exclude the tests from the final RPM. Please take a look. 2. The package hasn't been updated in three years :-(, but someone developed a patch this year, which I've integrated: https://github.com/huggingface/spm_precompiled/pull/4 3. I agree about the grammar. I'll prepare a more comprehensive changeset (for ex, fixing README.md or tweaking Cargo.toml so that rust2rpm can summarize it) if you like the direction so far. 4. It seems like the "precompiled" phrase comes from the fact that this Rust implementation parses the "precompiled_charsmap" generated by Google's SentencePiece library: https://github.com/google/sentencepiece/blob/273449044caa593c2fd7eb7550cb3ab2cff93f1a/src/sentencepiece_model.proto#L252 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358524%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
