https://bugzilla.redhat.com/show_bug.cgi?id=2358524 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking this review - some initial comments: 1. This crate ships base64-encoded binary data that I can't really tell the origin of (test.json). It looks like that is only used as input for tests - at the very least, it should be excluded from built packages. 2. The dependency on base64 v0.13 is very outdated, it would be good to get this updated to v0.22 upstream (and in this package). 3. There are multiple typos in the crate's description and documentation (it should be "its Normalizer", not "it's Normalizer"), would be great to get that fixed upstream too :) 4. The "precompiled" in the name initially threw me off, but it looks like this crate actually doesn't contain any pre-compiled stuff, it is used for *handling* precompiled data of some sort? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358524%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
