[Bug 2353869] Review Request: libmbd - Many-body dispersion library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2353869



--- Comment #12 from Cristian Le <fedora@xxxxxxxxx> ---
> d) /usr/lib64/openmpi/lib/cmake ...
> Probably want to require gcc-gfortran for libmbd-devel
> For the openmpi folders, may need to co-own them or require openmpi-devel

This sounds like something that should be patched in the `gfortran`/`openmpi`
etc. packages. Something like the .attr [1]. For now though, I think it would
make sense to explicitly include them, especially since I have my doubts on how
well the cmake/fortran files are designed and if they don't have an implicit
dependency on the mpi libraries.

Would be nice to untangle them at some point because it technically can work as
a C header package

> c) To check linking, create a copr and build Quantum Expresso or do this in a side-tag. Thanks for unbundling libmbd.
> I can also check with https://dftbplus.org

See https://github.com/LecrisUT/FedoraRPM-quantum-espresso. Request me builder
access to the linked copr (can find it in the packit builds) and I will add
you.

> b) Issues from fedora-review:
> libmbd-openmpi.x86_64: E: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libmbd.so.0.13.0 /lib64/libgcc_s.so.1
> libmbd.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libmbd.so.0.13.0 /lib64/libgcc_s.so.1
> libmbd-mpich.x86_64: E: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libmbd.so.0.13.0 /lib64/libgcc_s.so.1
> Not sure why this is. Investigating

I did raise it in the devel chat but the source is still unknown. We do have
`-Wl,--as-needed` hard-coded so there is nothing that we can do on this end to
untangle that issue other than manually patching out, which I want to avoid
right now. It may be a Fortran/gfortran weirdness as usual. On the other hand,
it is harmless right now.

> libmbd-openmpi.x86_64: W: summary-not-capitalized libmbd - openmpi version
> libmbd-mpich.x86_64: W: summary-not-capitalized libmbd - mpich version
>
> Consider just writing Libmd rather than using %name

Do we have a third option? I wish to still have the exact package reference
similar to the `-devel` ones so that it is more directly linked.

> a) Koji build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=132917945
>
> Some tests fail on s390x

Oops thanks for the catch, I have reported it upstream [2], but for now I a
excluding the architecture since quantum-espresso is also excluding it. My
understanding is that you would need this for dftbplus as well, which is not
packaged yet (ping me for review on that one if you need)? We can coordinate
later if we want to relax this?

[1]: https://src.fedoraproject.org/rpms/cmake/blob/rawhide/f/cmake.attr
[2]: https://github.com/libmbd/libmbd/issues/76


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2353869

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353869%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux