https://bugzilla.redhat.com/show_bug.cgi?id=2364345 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Regarding the two manual changes I see from rust2rpm’s output, first: -License: LGPL-2.1 +License: LGPL-2.1-or-later Based on the LGPL-2.1-or-later license notice I see in org.freedesktop.UDisks2.xml, it seems like this is a justifiable correction to the deprecated LGPL-2.1 SPDX identifier. However: - This should be patched in Cargo.toml (with rust2rpm -p), not just in the spec file - You should ask upstream to fix this in Cargo.toml and link the PR: https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ And second: +sed -i '1d' ./src/lib.rs This removes the line #![doc = include_str!("../README.md")] Sed-patches are still patches: this really ought to have a comment explaining what is happening and why, and either linking an upstream report/PR or explaining why it makes sense for the change to be downstream-only. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2364345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202364345%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
