https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Pramod V U <pramodvu1502@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pramodvu1502@prot | |on.me) | --- Comment #44 from Pramod V U <pramodvu1502@xxxxxxxxx> --- So, - I will remove "Provides:"... - %pre script is needed... Ideally cron.target is enabled by default and functional at installation... As per the "preset"... The - I will remove `mkdir /etc/cron,d` - I am collecting a few things to PR together... Now I will within fork and PR a few days - I *am* using the _systemdgeneratordir macro now... - I will use %{url}/archive/v%{version}.tar.gz - %{url}/archive/v%{version}/%{name}-%{version}.tar.gz is "Not found"; I'll just use %{url}/archive/v%{version}.tar.gz BTW, here are some things I need to know from more experienced packagers, - Is the cron-update.{path,service} needed? It basically runs `systemctl daemon-reload` whenever cron files are touched. - I run `%{_bindir}/systemctl reload-or-restart systemd-sysusers.service systemd-tmpfiles-setup.service` in %post - In order to get the required users and directory ready right after install. Atleast the tmpfiles.d thing is needed... - Creating the directory in %install or %post is a tricky issue regarding the "crontab" group the directory needs to be set to. - I will also change (in my PR) the user and group handling from `systemd-sysusers` to systemd's JSON user/group record format... Should I (in context of fedora I am asking)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c44 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
