https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Dick Marinus <dick@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(pramodvu1502@prot | |on.me) --- Comment #43 from Dick Marinus <dick@xxxxxxx> --- Great, please have a look at the following - "Provides: cronie" is wrong in my eyes - I think the %pre script should be removed (as it isn't started anymore) - You can omit creating empty directories (/etc/cron.d), it will be automatically managed by %dir in %files - It would be really nice to have 50-systemd-cron.preset and/or systemd-cron.conf provided by upstream, have you tried to get these added using a PR? - Use the _systemdgeneratordir macro - Use the suggested Url: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c43 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
