https://bugzilla.redhat.com/show_bug.cgi?id=2346041 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |CLOSED Last Closed| |2025-05-06 23:58:01 --- Comment #40 from Carl George 🤠 <carl@xxxxxxxxxx> --- I recognize that this review was posted before the one in bug 2361484. Normally I would stick with the original review and close subsequent ones as duplicates, but in this case Michel's spec file is in much better shape than this one. I agree with the previously stated points about proper attribution for things borrowed from other distributions. In particular the man pages should be sent to the upstream project, no just cargo culted around. Since you're already copying in sections of his spec file, I think the best path forward is to just approve his review, and then he can add you as a co-maintainer after it's imported to distgit. For that reason, I'm closing this review as a duplicate of Michel's. I hope this is an acceptable compromise to you to move this package forward. *** This bug has been marked as a duplicate of bug 2361484 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2346041 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346041%23c40 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
