https://bugzilla.redhat.com/show_bug.cgi?id=2347551 Srisharan V S <srisharan.psgtech@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srisharan.psgtech@xxxxxxxxx --- Comment #4 from Srisharan V S <srisharan.psgtech@xxxxxxxxx> --- MOCK REVIEW: 1. The spec looks clean and adheres to Fedora packaging conventions. 2. Consider adding `%post` and `%postun` scriptlets since your package installs `.desktop` files and icon assets. These ensure the desktop database and icon cache are properly updated on install/uninstall: Maybe refer this, - https://fedoraproject.org/wiki/Desktop_Documentation_Presentation_Options-Example-spec - https://fedoraproject.org/wiki/NewMIMESystem Overall, great work! With the above tweak, the package would be even more robust and compliant. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2347551 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202347551%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
