https://bugzilla.redhat.com/show_bug.cgi?id=2347551 --- Comment #3 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > a) May need the hicolor-icon-theme package Oops. Added. > b) Please adapt the Makefile to use to get position independent executable Done through a sed invocation. > c) Please use desktop-file install or desktop-file-validate Fixed. Also wrote an AppStream metainfo file. > d) Do package the documentation Done. > e) Consider packaging the CC license file as well Fixed. Also added the file containing full GPL text. spec: https://suve.fedorapeople.org/review/alexvsbus-2024.11.21.0-2/alexvsbus.spec srpm: https://suve.fedorapeople.org/review/alexvsbus-2024.11.21.0-2/alexvsbus-2024.11.21.0-2.fc42.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=130885739 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2347551 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202347551%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue