https://bugzilla.redhat.com/show_bug.cgi?id=2359302 --- Comment #4 from Thiago Sueto <herzenschein@xxxxxxxxx> --- I have updated the spec and added it to a pagure repository: https://pagure.io/qman/blob/master/f/qman.spec As before the builds are available on COPR: https://copr.fedorainfracloud.org/coprs/herzenschein/qman/ > a) Please replace: > Source0: https://github.com/plp13/%{name}/archive/refs/tags/v%{version}.tar.gz > by > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz How did you find that link? I can't seem to find it on Github. >A simpler (and perhaps more correct) way to fix the error you were having would >be to correct the signature of the sigusr1_handler function: I'm getting an error when attempting to add the patch: ``` + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/lib/rpm/rpmuncompress /builddir/build/SOURCES/sigurs1_handler.patch + /usr/bin/patch -s --fuzz=0 --no-backup-if-mismatch -f The text leading up to this was: -------------------------- |--- a/src/tui.c 2025-04-12 08:55:10.000000000 -0300 |+++ b/src/tui.c 2025-04-13 00:19:48.009633599 -0300 -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored error: Bad exit status from /var/tmp/rpm-tmp.sySLid (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.sySLid (%prep) ``` Also, would this require that I make an upstream bug report, as mentioned in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment ? I see upstream has just fixed this 11 hours ago, I'm not sure how to proceed: https://github.com/plp13/qman/commit/68c705134fd8524770258e2b28386afe5c01036c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2359302 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202359302%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
