https://bugzilla.redhat.com/show_bug.cgi?id=2359302 Gustavo Costa <xfgusta@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xfgusta@xxxxxxxxx --- Comment #3 from Gustavo Costa <xfgusta@xxxxxxxxx> --- ``` # -Wincompatible-pointer-types issue with gcc introduced in 1.4.0 %global build_type_safety_c 2 ``` A simpler (and perhaps more correct) way to fix the error you were having would be to correct the signature of the sigusr1_handler function: ``` --- a/src/tui.c 2025-04-12 08:55:10.000000000 -0300 +++ b/src/tui.c 2025-04-13 00:19:48.009633599 -0300 @@ -160,7 +160,7 @@ // Re-configure the program. `init_tui()` makes sure this is called whenever // `SIGUSR1` is received. -void sigusr1_handler() { +void sigusr1_handler(int signum) { // Don't attempt attempt to reconfigure on ancient terminals if (tcap.colours < 256 || tcap.term == strstr(tcap.term, "rxvt")) { return; ``` Consider changing ``` BuildRequires: xz-devel BuildRequires: CUnit-devel ``` to ``` BuildRequires: pkgconfig(liblzma) BuildRequires: pkgconfig(cunit) ``` Consider using this description from qman man page [1]: ``` %description Qman is a modern, interactive manual page viewer for our terminals. It strives to be easy to use for anyone familiar with the man(1) command, and also to be fast and tiny, so that it can be used everywhere. ``` Consider removing PACKAGING.md and TESTING.md, as these files are not useful to be installed [2]: ``` %install %meson_install rm -v %{buildroot}/%{_datadir}/doc/%{name}/{PACKAGING,TESTING}.md ``` You need to use this pattern for the man page [3]: ``` %{_mandir}/man1/%{name}.1* ``` 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description 2. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2359302 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202359302%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
