https://bugzilla.redhat.com/show_bug.cgi?id=2355279 --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Vít Ondruch from comment #1) > A few comments. > > 1) If you keep something like `#Source: > https://rubygems.org/gems/%%{gem_name}-%%{version}.gem`, you can try to go > with `%dnl`. I.e. `%dnl Source: > https://rubygems.org/gems/%{gem_name}-%{version}.gem`. That way, you don't > have to escape the `%`. > Thanks. > 2) What is the reason to go with the upstream tarball anyway? Is it the > test? Isn't it better to include just the test separately? > The gem does not contain tests. It seems more maintenance to package tests separately, would still need to get source from git repository. > 3) I'd suggest to improve the `description`. I see it comes from the > .gemspec like that, but we don't need to stick with that. The initial > paragraph from the README would be likely much better description. > Ok. Done. > 4) We typically execute the test suite under `.%{gem_instdir}`. And this > actually might be related to (2). The reason is that the content in > `.%{gem_instdir}` is what is used in `%install` section. If there were done > some modifications, you'd like to test those. > Tests are not installed, .%{gem_instdir} contains: . ├── LICENSE ├── README.md └── lib └── tcxread.rb Can raise an issue upstream if this is non-standard. > 5) I have some sympathy for `%exclude %{gem_docdir}/rdoc` (because the > situation could be better), but is it really worth of it? Guess can ask upstream. For python, found that sphinx can generate different themes, and there is a theme in Fedora without javascript: https://gitlab.com/lv2/sphinx_lv2_theme Would be good to make something like this for the Ruby ecosystem or at least the Fedora Ruby ecosystem. A single page html file need not use javascript since and fonts can be shared across all gem documentation. Most html viewers have search functionality. There is also ridoc. It seems that there is interest in RDoc themes: https://www.rorvswild.com/blog/2024/rorvswild-rdoc-theme https://github.com/BaseSecrete/rorvswild-theme-rdoc Though may want to choose a Fedora color palette. Updated: spec: https://fed500.fedorapeople.org/rubygem-tcxread.spec srpm: https://fed500.fedorapeople.org/rubygem-tcxread-0.2.0-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2355279 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202355279%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
