https://bugzilla.redhat.com/show_bug.cgi?id=2355279 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- A few comments. 1) If you keep something like `#Source: https://rubygems.org/gems/%%{gem_name}-%%{version}.gem`, you can try to go with `%dnl`. I.e. `%dnl Source: https://rubygems.org/gems/%{gem_name}-%{version}.gem`. That way, you don't have to escape the `%`. 2) What is the reason to go with the upstream tarball anyway? Is it the test? Isn't it better to include just the test separately? 3) I'd suggest to improve the `description`. I see it comes from the .gemspec like that, but we don't need to stick with that. The initial paragraph from the README would be likely much better description. 4) We typically execute the test suite under `.%{gem_instdir}`. And this actually might be related to (2). The reason is that the content in `.%{gem_instdir}` is what is used in `%install` section. If there were done some modifications, you'd like to test those. 5) I have some sympathy for `%exclude %{gem_docdir}/rdoc` (because the situation could be better), but is it really worth of it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2355279 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202355279%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
