https://bugzilla.redhat.com/show_bug.cgi?id=2344240 --- Comment #17 from Sam Day <me@xxxxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/samcday/fedora-msm8916/refs/heads/main/specs/rust-wayland-protocols-misc/rust-wayland-protocols-misc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/samcday/msm8916/fedora-rawhide-aarch64/08832070-rust-wayland-protocols-misc/rust-wayland-protocols-misc-0.3.6-1743238254.fc43.src.rpm (In reply to Fabio Valentini from comment #16) > 1. There's a new version out (0.3.6), Updated! > 2. It looks like the Source URL for the COPYING.LIB file can't be parsed by > RPM (or by spectool) Oops, I did notice that before and had already fixed it before even updating the review, but the srpm was slightly older and still had that :S Anyways, fixed now. > 3. The way you list the license texts under %files causes duplicates to be > included: Took me a while to wrap my brain around this but I properly understand now. I didn't realize that the licenses for rust-* packages are *not* supposed to go in `/usr/share/licenses` and instead `rpm -qL rust-foo` should point to `/usr/share/cargo/registry/foo/LICENSE`. > Using a matching filename for the latter might be good to -- something like > "LICENSE-LGPL-2.1.txt" maybe? Or just keep it as "COPYING.LIB"? I opted for "LICENSE-LGPL-2.1.txt" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2344240 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202344240%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
